Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Put labels over drops #234

Merged
merged 3 commits into from
Mar 26, 2018
Merged

[RFR] Put labels over drops #234

merged 3 commits into from
Mar 26, 2018

Conversation

jpetitcolas
Copy link
Contributor

In some case (for instance in #51), we may need to display labels inside drop lines instead of outside them. It is achievable using a negative label padding, such as:

const chart = eventDrops({
    label: {
        padding: -200,
    },
};

Yet, before this PR, drops were above the labels, causing some display issues:

screenshot-2018-3-21 event drops demo 1

With these changes, the text would be above the drops:

screenshot-2018-3-21 event drops demo 2

Closes #51.

@jdemangeon jdemangeon merged commit 63b73c2 into master Mar 26, 2018
@jdemangeon jdemangeon deleted the inside_labels branch March 26, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants