-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom improvements #269
Open
Busteren
wants to merge
9
commits into
marmelab:master
Choose a base branch
from
Busteren:zoomImprovements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Zoom improvements #269
Commits on May 13, 2019
-
Added zoom to domain function. This allows to zoom to a given domain programmatically. Added id in config, reason for this is that when connecting two EventDrops chart, it is very handy to have the id in the svg element the zoom is happening in.
Configuration menu - View commit details
-
Copy full SHA for a571bb9 - Browse repository at this point
Copy the full SHA a571bb9View commit details -
Added the option to restrict panning (dragging behaviour) to the initial date range. So if the date range is from 2010 to 2012, it is not possible to pan to say 2009. If the minimumScale is less than 1, it is possible to zoom out, however panning will be disabled so that it is not possibel to pan to say an earlier date. ZoomToDomain function will ignore this (this is default D3 behaviour).
Configuration menu - View commit details
-
Copy full SHA for 6d9c83b - Browse repository at this point
Copy the full SHA 6d9c83bView commit details
Commits on May 15, 2019
-
Removed redundant casting to date
As we expect the dates to be already formmatted, I don't think it is neccessary to cast them to dates again.
Configuration menu - View commit details
-
Copy full SHA for be26541 - Browse repository at this point
Copy the full SHA be26541View commit details -
Added optional arguments to zoomToDomain to allow for transition.
Configuration menu - View commit details
-
Copy full SHA for 9d6ac89 - Browse repository at this point
Copy the full SHA 9d6ac89View commit details
Commits on May 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a0c6cb9 - Browse repository at this point
Copy the full SHA a0c6cb9View commit details
Commits on May 24, 2019
-
Removed id as this is simple to add manually. Chnaged to restrictPan to restrictpan so it could be referenced in MD file (if someone knows how to reference in uppercase, please change). Added in a check to see if _zoomToDomain is defined as function, if not then throw error. Renamed zoomObject to zoom as it is more consistent with other D3 example code. Zoom is now zoomFactory. Removed unused code in test for index. Changelog, configuration doc and Readme updated.
Configuration menu - View commit details
-
Copy full SHA for 28d0058 - Browse repository at this point
Copy the full SHA 28d0058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40cf68a - Browse repository at this point
Copy the full SHA 40cf68aView commit details
Commits on Aug 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9d6fb72 - Browse repository at this point
Copy the full SHA 9d6fb72View commit details
Commits on Aug 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b5c5a7c - Browse repository at this point
Copy the full SHA b5c5a7cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.