Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom improvements #269

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Commits on May 13, 2019

  1. Zoom to domain and id to svg

    Added zoom to domain function. This allows to zoom to a given domain programmatically.
    
    Added id in config, reason for this is that when connecting two EventDrops chart, it is very handy to have the id in the svg element the zoom is happening in.
    Busteren committed May 13, 2019
    Configuration menu
    Copy the full SHA
    a571bb9 View commit details
    Browse the repository at this point in the history
  2. Restriction to pan

    Added the option to restrict panning (dragging behaviour) to the initial date range. So if the date range is from 2010 to 2012, it is not possible to pan to say 2009.
    If the minimumScale is less than 1, it is possible to zoom out, however panning will be disabled so that it is not possibel to pan to say an earlier date.
    ZoomToDomain function will ignore this (this is default D3 behaviour).
    Busteren committed May 13, 2019
    Configuration menu
    Copy the full SHA
    6d9c83b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Removed redundant casting to date

    As we expect the dates to be already formmatted, I don't think it is neccessary to cast them to dates again.
    Busteren committed May 15, 2019
    Configuration menu
    Copy the full SHA
    be26541 View commit details
    Browse the repository at this point in the history
  2. Optional transition on zoom

    Added optional arguments to zoomToDomain to allow for transition.
    Busteren committed May 15, 2019
    Configuration menu
    Copy the full SHA
    9d6ac89 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2019

  1. Attempting to fix CI

    Busteren committed May 19, 2019
    Configuration menu
    Copy the full SHA
    a0c6cb9 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Removed id and review changes

    Removed id as this is simple to add manually.
    Chnaged to restrictPan to restrictpan so it could be referenced in MD file (if someone knows how to reference in uppercase, please change).
    Added in a check to see if _zoomToDomain is defined as function, if not then throw error.
    Renamed zoomObject to zoom as it is more consistent with other D3 example code.
    Zoom is now zoomFactory.
    Removed unused code in test for index.
    Changelog, configuration doc and Readme updated.
    Busteren committed May 24, 2019
    Configuration menu
    Copy the full SHA
    28d0058 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40cf68a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Configuration menu
    Copy the full SHA
    9d6fb72 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Fixed typo restrictPan

    Busteren committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    b5c5a7c View commit details
    Browse the repository at this point in the history