-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker to create a dev env #34
Conversation
atilbian
commented
Feb 21, 2022
•
edited
Loading
edited
- Allow to develop into docker
- Hide env files from git
- Update readme
1c45f71
to
a37ce54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deployment folder seems like "the whole lot of stuff that makes the deployment work".
As for the rest of the code, we can organize it by domain (ie. domain = infra here) :
/backend
package.json
.env.*
Dockerfile
/app
package.json
.env.*
Dockerfile
docker-compose.yml
docker-compose.prod.yml
Makefile
As for all the docker settings and conf files that are not directly linked to my project (e.g. nginx), I like to regroup them in their own .docker
folder:
/.docker
/nginx
nginx.conf
/postgres
/data
pg.conf
What's behind "app" and "backend" in your example ? Seems 2 differents things for me so we don't need to share a common docker compose file between each ? |
To reduce final image size