Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker to create a dev env #34

Merged
merged 8 commits into from
Feb 21, 2022
Merged

Use docker to create a dev env #34

merged 8 commits into from
Feb 21, 2022

Conversation

atilbian
Copy link
Collaborator

@atilbian atilbian commented Feb 21, 2022

  • Allow to develop into docker
  • Hide env files from git
  • Update readme

@atilbian atilbian added the WIP label Feb 21, 2022
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deployment/.env.dev.dist Outdated Show resolved Hide resolved
deployment/Dockerfile.prod Outdated Show resolved Hide resolved
deployment/docker-compose.prod.yaml Outdated Show resolved Hide resolved
deployment/docker-compose.prod.yaml Outdated Show resolved Hide resolved
deployment/docker-compose.yaml Outdated Show resolved Hide resolved
Copy link

@floo51 floo51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment folder seems like "the whole lot of stuff that makes the deployment work".
As for the rest of the code, we can organize it by domain (ie. domain = infra here) :

/backend
    package.json
    .env.*
    Dockerfile
/app
    package.json
    .env.* 
    Dockerfile
docker-compose.yml
docker-compose.prod.yml
Makefile

As for all the docker settings and conf files that are not directly linked to my project (e.g. nginx), I like to regroup them in their own .docker folder:

/.docker
    /nginx
         nginx.conf
    /postgres
         /data
         pg.conf

deployment/docker-compose.yaml Outdated Show resolved Hide resolved
deployment/docker-compose.yaml Outdated Show resolved Hide resolved
@atilbian
Copy link
Collaborator Author

What's behind "app" and "backend" in your example ? Seems 2 differents things for me so we don't need to share a common docker compose file between each ?

@atilbian atilbian added RFR and removed WIP labels Feb 21, 2022
@Clebiez Clebiez merged commit 6ad39dd into main Feb 21, 2022
@Clebiez Clebiez deleted the use-docker-for-dev branch February 21, 2022 17:01
@slax57 slax57 mentioned this pull request Feb 24, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants