Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin api find routes for games #66

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Add admin api find routes for games #66

merged 5 commits into from
Mar 2, 2022

Conversation

slax57
Copy link
Collaborator

@slax57 slax57 commented Mar 1, 2022 •
edited
Loading

Content

  • The computed status (INITIALIZED, RUNNING or ENDED) is now stored in db, in order to be able to filter on this column
  • Create a service with basic findOne() and findMany() implementations
  • Create a controller to expose these operations to REST API routes

Relates to: https://trello.com/c/HSUZcSyK/37-3-as-norbert-i-want-to-be-able-to-see-all-games-and-be-able-to-delete-some

Demo

hex-api-admin-games

NB: Demo contains features that will only be available in the next PR #67

@slax57 slax57 added the WIP label Mar 1, 2022
@slax57 slax57 force-pushed the feature-add-admin-api-route-for-games branch from 1cdc067 to 84492fe Compare March 2, 2022 09:33
@slax57 slax57 changed the title Add admin api routes for games Add admin api find routes for games Mar 2, 2022
@slax57 slax57 added RFR and removed WIP labels Mar 2, 2022
atilbian
atilbian reviewed Mar 2, 2022
View reviewed changes
web-app/src/games/games.service.ts Outdated Show resolved Hide resolved
web-app/src/games/games.service.ts Show resolved Hide resolved
@slax57 slax57 mentioned this pull request Mar 2, 2022
Open
@atilbian atilbian merged commit 8f30ed3 into main Mar 2, 2022
@atilbian atilbian deleted the feature-add-admin-api-route-for-games branch March 2, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atilbian atilbian atilbian left review comments

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slax57 @fzaninotto @djhi @atilbian