Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redux-form to 7.1.X #1657

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

mauchede
Copy link

Hello,

We have some warnings on api-platform/admin due to redux-form.

Update redux-form to (at least) 7.1.0 resolves the problem (I used 7.1.1 because 7.1.0 had a problem with immutablejs).

According to your version policy, I kept tilde for version range.

@fzaninotto
Copy link
Member

I'm not sure we'll merge this, as we're limiting updates on the master branch.

@mauchede
Copy link
Author

mauchede commented Mar 16, 2018

I understand you want to be focus on next branch. But the warnings are very noisy: on Travis we have more "warning" lines than "legit" lines. Your project also has the problem but it is printed only once

We have only two possibilities:

  • run Jest with --silent flag.
  • force npm / yarn to retrieve a fixed version.

Unfortunately, these solutions are not acceptable.

This fix will give some time for all projects that depending of admin-on-rest (like our project) to prepare the update to next version.

By the way, the problem is also present on next. If you wish, I can make another PR for next branch.

@fzaninotto fzaninotto added this to the 1.4.1 milestone Mar 26, 2018
@fzaninotto fzaninotto merged commit 07bf9a4 into marmelab:master Mar 26, 2018
@fzaninotto
Copy link
Member

Thanks

@mauchede
Copy link
Author

Thank you for merging!

@mauchede mauchede deleted the fix/remove-warnings branch March 27, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants