New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 'object' propType in 'to' prop of 'MenuItemLink' #2584

Merged

fzaninotto merged 1 commit into marmelab:master from afilp:fix-menuItemLink-proptypes

Nov 28, 2018

Contributor

afilp commented Nov 27, 2018

As documented in react-router, the <NavLink> component can have either string or object type for its `to' property:

https://reacttraining.com/react-router/web/api/Link

Some developers use it as such:

              <MenuItemLink
                to={{
                  pathname: '/departments',
                }}
                primaryText="departments"
                title="departments"
                onClick={onMenuClick}
                leftIcon={<BusinessIcon />}
              />


          Allow 'object' propType in 'to' prop

d705e71

fzaninotto merged commit caeffe3 into marmelab:master

Member

fzaninotto commented Nov 28, 2018

Thanks!

fzaninotto added this to the 2.4.4 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet