Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit autocomplete height on AutocompleteArrayInput #2914

Merged

Conversation

tiagoschenkel
Copy link
Contributor

The component AutocompleteArrayInput will render all the choices in a full container without scroll options. This is not a good idea when dealing with huge lists, as a list of possible countries in the world.

The property choicesMaxHeight will limit the size of the choices container, enabling the scrolling of the content.

@tiagoschenkel tiagoschenkel changed the title Added choicesMaxHeight property to AutocompleteArrayInput Add choicesMaxHeight property to AutocompleteArrayInput Feb 22, 2019
@fzaninotto
Copy link
Member

Please reproduce what's been done on the <AutocompleteInput> component instead (limiting the choices paper to 50% of the screen).

@tiagoschenkel tiagoschenkel changed the base branch from next to master February 25, 2019 10:51
@tiagoschenkel tiagoschenkel changed the title Add choicesMaxHeight property to AutocompleteArrayInput Limit autocomplete height on AutocompleteArrayInput Feb 25, 2019
@tiagoschenkel
Copy link
Contributor Author

Removed the parameter choicesMaxHeight and implemented same changes added to AutocompleteInput (#2415).

This pull request is now against master since would be considered as a bug fix instead of a new feature.

@djhi djhi added this to the 2.7.3 milestone Feb 26, 2019
@fzaninotto fzaninotto merged commit f8683ff into marmelab:master Feb 26, 2019
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants