Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Update documentation with German translation package #3014

Merged
merged 1 commit into from
Mar 18, 2019
Merged

[RFR] Update documentation with German translation package #3014

merged 1 commit into from
Mar 18, 2019

Conversation

straurob
Copy link

This PR adds a link to the translation section. It refers to a new standalone package for the German translations of the ra-tree-ui-materialui package as propsed in PR #2998.

Due to problems with my local repo I had to recreate the fork. Thus, PR #3011 is obsolete and can be continued here.

@fzaninotto
Copy link
Member

hm, this one is even worse than the previous one...

@straurob
Copy link
Author

Let's see if the latest change looks better. I'm sorry... this is embarassing :-|

@fzaninotto fzaninotto merged commit ed7f2d5 into marmelab:next Mar 18, 2019
@fzaninotto
Copy link
Member

Yep, that one is all right. Thanks!

@fzaninotto fzaninotto added this to the 2.8.2 milestone Mar 18, 2019
@straurob
Copy link
Author

@fzaninotto
I just stumpled upon this. This PR was added to the 2.8.2 milestone and is also listed in the corresponding changelog. However I don't see the commit in the actual file.

https://github.com/marmelab/react-admin/blob/v2.8.2/docs/Translation.md

Could you check this?

@fzaninotto
Copy link
Member

ah, it's been pushed against next rather than master. I didn't pay attention before merging. So this will appear in the next minor release.

@straurob
Copy link
Author

straurob commented Apr 1, 2019

Ah ok, I understand. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants