fix: expand icon overlaps actions in tree view #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On certain material-ui versions, the expand icon stretches the whole TreeNode width, because we set it to `left: ...` but material-ui sets it to `right: ...`. I am force to use 3.9.2, but this was already the case in the used version 1.4.0. This is fixed in material-ui 4 in this commit: mui/material-ui@7b0f7d5 until then, setting `right: auto` on the expandIcon in the TreeNode will fix it for every version
fzaninotto
approved these changes
Apr 2, 2019
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On certain material-ui versions, the expand icon stretches the whole TreeNode width, because we set it to
left: ...but material-ui sets it toright: ....I am force to use 3.9.2, but this was already the case in the used version 1.4.0.
This is fixed in material-ui 4 in this commit: mui/material-ui@7b0f7d5
until then, setting
right: autoon the expandIcon in the TreeNode will fix it for every version