Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Authenticate NotFound page #3243

Merged
merged 1 commit into from
May 24, 2019
Merged

[RFR] Authenticate NotFound page #3243

merged 1 commit into from
May 24, 2019

Conversation

Kmaschta
Copy link
Contributor

Fixes #3230

@Kmaschta Kmaschta added this to the 3.0.0 milestone May 17, 2019
djhi
djhi reviewed May 20, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. If there are pages accessible anonymously, shouldn't we have an anonymous compatible 404 support?

@Kmaschta
Copy link
Contributor Author

How can we see that there is anonymous-accessible pages?

I agree, but currently we have a big part of the app (layout, custom menu, etc) that are accessible by un-logged people.

@fzaninotto fzaninotto merged commit ade3229 into next May 24, 2019
@fzaninotto fzaninotto deleted the authenticate-not-found-page branch May 24, 2019 10:02
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi left review comments

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kmaschta @fzaninotto @djhi