Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused filter prop which in useGetMatchingReference #4314

Merged
merged 1 commit into from Jan 21, 2020
Merged

Remove the unused filter prop which in useGetMatchingReference #4314

merged 1 commit into from Jan 21, 2020

Conversation

Luwangel
Copy link
Contributor

@Luwangel Luwangel commented Jan 17, 2020 •
edited

Fix #4313

The useGetMatchingReference hook has an unused property: filter. So I just remove it.

Todo

  • Remove the unused prop
  • Fix tests if broken

@Luwangel Luwangel added WIP Work In Progress RFR Ready For Review and removed WIP Work In Progress labels Jan 17, 2020
@fzaninotto fzaninotto merged commit a1b0359 into master Jan 21, 2020
@fzaninotto fzaninotto deleted the remove-unused-var branch January 21, 2020 16:59
@fzaninotto fzaninotto added this to the 3.1.3 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

useGetMatchingReferenceSelector prop defined but not used.
2 participants
@Luwangel @fzaninotto