Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Datagrid column headers don't update sort indicator when used in ReferenceManyField #4346

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix Datagrid column headers don't update sort indicator when used in ReferenceManyField #4346

merged 1 commit into from
Jan 28, 2020

Conversation

fzaninotto
Copy link
Member

Closes #4178

@fzaninotto fzaninotto added the RFR Ready For Review label Jan 23, 2020
@fzaninotto fzaninotto added this to the 3.1.4 milestone Jan 23, 2020
djhi
djhi requested changes Jan 23, 2020
View reviewed changes
packages/ra-ui-materialui/src/list/DatagridHeaderCell.js
export const DatagridHeaderCell = props => {
const {
className,
classes: classesOverride,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't want to destructure this one or it won't be passed to useStyles preventing overrides

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm passing props to useStyles, not rest. Destructuring as classesOverride here avoids the name conflict with the useStyles return value.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read too quickly...

@djhi djhi merged commit 2a409ac into master Jan 28, 2020
@djhi djhi deleted the fix-sort-icon-doesnt-show-in-in-referencemanyfield branch January 28, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

Column headers for Datagrid in ReferenceManyField don't update sort indicator
2 participants
@fzaninotto @djhi