Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Use AutocompleteInput instead of SelectInput in filterToQuery examples #4461

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

leibowitz
Copy link
Contributor

@leibowitz leibowitz commented Feb 28, 2020

I believe the filterToQuery prop on ReferenceInput is passed onto the children prop as setFilter, as the doc states in this section:

The child component receives the following props from <ReferenceInput>:

  • setFilter: function to call to update the filter of the request for possible values

This seems to only matter to the AutocompleteInput. But the examples all use a SelectInput, which (as far as I'm aware) doesn't do anything with it. Correct me if I'm wrong, but I guess it was meant to be using an AutocompleteInput instead.

@leibowitz leibowitz changed the title Use AutocompleteInput instead of SelectInput in filterToQuery examples DOC: Use AutocompleteInput instead of SelectInput in filterToQuery examples Feb 28, 2020
@leibowitz leibowitz changed the title DOC: Use AutocompleteInput instead of SelectInput in filterToQuery examples Doc: Use AutocompleteInput instead of SelectInput in filterToQuery examples Feb 28, 2020
@fzaninotto fzaninotto merged commit 18ac414 into marmelab:master Mar 5, 2020
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants