[RFR] Support array of objects in sanitizeEmptyValues #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armellarcier
force-pushed
the
fix-sanitizeEmptyValues-4726
branch
2 times, most recently
from
8f2437c
to
73f8ac4
Compare
armellarcier
force-pushed
the
fix-sanitizeEmptyValues-4726
branch
from
73f8ac4
to
b603381
Compare
|
Thanks! |
|
Glad I could help. As I stated in the PR description, this fixes a problem and should be a good solution for the vast majority of use cases but an array being what it is, reordering an array of objects with different structures will lead to props with null values in objects that didn’t have the prop in the first place. This is not perfect. Maybe the |
| @@ -16,8 +16,16 @@ const sanitizeEmptyValues = (initialValues: object, values: object) => { | |||
| if (!initialValues) return values; | |||
| const initialValuesWithEmptyFields = Object.keys(initialValues).reduce( | |||
| (acc, key) => { | |||
| if (values[key] instanceof Date || Array.isArray(values[key])) { | |||
There was a problem hiding this comment.
What if values is null or undefined? is it possible? shouldn't there be an if for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4726
This will not support an array of objects with different structure AND key reordering.