Fix CreateButton does not update on 'to' prop change #5014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the
CreateButton
to reflect the filter values to prefill the new item form. The use case is like this:It worked almost fine except I needed to refresh the page after setting the filter to make the
to
property be in sync with the filter (. After some research I found out that this button is exported viamemo
and it's not updated if theto
prop is changed. I replaced theTopToolbar
inList
and the button is declared like this:When I used a regular button it worked just fine. Not all buttons in
ra-ui-materialui
are wrapped intomemo
(the other two I found areShowButton
andCloneButton
), I'm not sure if this is an important optimization or if it has some deeper meaning but apparently it might cause this subtle bugs.