Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set notification over confirms dialog, not under #5073

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Set notification over confirms dialog, not under #5073

merged 1 commit into from
Jul 22, 2020

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Jul 22, 2020 •
edited
Loading

Closes #5071

Issue

Notification toasts are shown under confirms dialog.

Solution

Set notification toasts to be shown over confirms dialog, in the Layout component.

@JulienMattiussi JulienMattiussi added the RFR Ready For Review label Jul 22, 2020
@Luwangel Luwangel added this to the 3.8.0 milestone Jul 22, 2020
@Luwangel Luwangel merged commit e6ec6f6 into next Jul 22, 2020
@Luwangel Luwangel deleted the notifications-over-confirms branch July 22, 2020 10:35
@fzaninotto fzaninotto mentioned this pull request Jul 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienMattiussi @Luwangel