Fix Form Initialization from Record #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Aug 13, 2020
| }); | ||
| const initialValues = form.getState().initialValues; | ||
| const initialValuesMergedWithRecord = merge({}, initialValues, record); | ||
| form.initialize(initialValuesMergedWithRecord); |
There was a problem hiding this comment.
This is neat but there is a difference with the previous code: you initialize values including the ones for which there is no associated input. You put that restriction in 3e56efe. Are you sure you're not reintroducing a bug?
There was a problem hiding this comment.
Including the one from #3721?
There was a problem hiding this comment.
I'll add some tests tomorrow
|
ping |
djhi
force-pushed
the
fix-form-initialization-from-record
branch
from
1373500
to
20c9a90
Compare
fzaninotto
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4954