Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix ts code to js code in examples #5385

Merged
merged 1 commit into from
Oct 12, 2020
Merged

[Doc] Fix ts code to js code in examples #5385

merged 1 commit into from
Oct 12, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 12, 2020

No description provided.

Luwangel
Luwangel approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You're right, we should display the examples in JS :)

@Luwangel Luwangel added the RFR Ready For Review label Oct 12, 2020
@Luwangel Luwangel added this to the 3.9.5 milestone Oct 12, 2020
@Luwangel Luwangel merged commit 6897a5e into marmelab:master Oct 12, 2020
@WiXSL WiXSL deleted the fix-ts-to-js branch October 12, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
documentation RFR Ready For Review
Projects
None yet
Milestone
3.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @Luwangel