Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5426
This is only the beginning. Indeed there is a lot of work in order to provide type safe overrides.
See how MUI does it: https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/styles/overrides.d.ts#L103
I also wonder if our approach for the Sidebar
size
andclosedSize
configuration is correct. Maybe we should just rely on props with defaults (which can be overridden through the theme as well (https://material-ui.com/customization/globals/#default-props). This would lead to a single entry to customize the sidebar instead of two (sidebar
at the theme root andRaSidebar
in theoverrides
)We would have to export the class keys for every component like this:
This could be a very good opportunity for first time contributors