Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward compatibility between react-admin packages #5989

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

fzaninotto
Copy link
Member

Closes #5979

@fzaninotto fzaninotto added the RFR Ready For Review label Mar 3, 2021
@fzaninotto fzaninotto added this to the 3.13.2 milestone Mar 3, 2021
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have more packages depending on ra-core. Shouldn't we fix them as well?

@fzaninotto
Copy link
Member Author

I don't want to, because then we hit problems when a package hasn't been updated since long (e.g. ra-data-localstorage depends on ra-core@^3.9.0). I think putting a ~ in react-admin dependencies and keeping a ^ in cross-package dependencies is the good balance between security and ease of publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install react-admin 3.10.1 but get ra-core latest 3.13.0
2 participants