Fix useLogoutIfAccessDenied may notify more than once #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Apr 9, 2021
| @@ -8,6 +8,12 @@ const dataProvider = fakeRestProvider(data, true); | |||
| const uploadCapableDataProvider = addUploadFeature(dataProvider); | |||
| const sometimesFailsDataProvider = new Proxy(uploadCapableDataProvider, { | |||
| get: (target, name) => (resource, params) => { | |||
| // set session_ended=true in localStorage to trigger an API auth error | |||
| if (localStorage.getItem('session_ended')) { | |||
There was a problem hiding this comment.
this gives a way to simulate an API which invalidates credentials
fzaninotto
commented
Apr 9, 2021
|
|
||
| const logout = jest.fn(); |
There was a problem hiding this comment.
this was a bad idea and made me loose 1 hour scratching my head. Using authProvider.logout() in useLogout is way more natural.
djhi
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the dataProvider returns with an auth error (e.g. a 403 response), react-admin triggers a redirection to the login page and a notification message that the auth params are no longer valid.
This happens when the API invalidates the user credentials.
Now, if a page needs more than one dataProvider Request, this will cause several logouts (not a problem) and several notifications about auth params (that's a problem).
Solution
Check that the user is authenticated before notifying that their auth params are no longer valid