Fix warning in UrlField when value is nullish and emptyText is empty #6176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choosing between
are two distinct orthogonal decisions.
In my base my
value
wasundefined
and I didnt provide anemptyText
.Because of that
UrlField
tried to create aLink
leading to an annoying console warning, because it doesnt like thatchildren
is undefined.In the case the value is null, it is better to display an empty static text than an empty link.