Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleList: Add support for custom url #6594

Merged
merged 2 commits into from
Sep 27, 2021
Merged

SimpleList: Add support for custom url #6594

merged 2 commits into from
Sep 27, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Sep 17, 2021 •
edited
Loading

Closes #6592

@djhi djhi added the RFR Ready For Review label Sep 17, 2021
@djhi djhi added this to the 3.19 milestone Sep 17, 2021
@djhi
Copy link
Collaborator Author

djhi commented Sep 17, 2021

I also noticed the SimpleList might render a li item inside another li item which is of course wrong. I'll fix it as well

@djhi djhi added WIP Work In Progress and removed RFR Ready For Review labels Sep 17, 2021
@djhi djhi force-pushed the simplelist-custom-url-support branch from dac4459 to ff523b1 Compare September 27, 2021 08:38
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Sep 27, 2021
fzaninotto
fzaninotto reviewed Sep 27, 2021
View reviewed changes
packages/ra-ui-materialui/src/list/SimpleList.tsx Outdated
@@ -131,7 +131,8 @@ const SimpleList = <RecordType extends Record = Record>(
record={data[id]}
>
<ListItem
button={!!linkType as any}
// Ensure we don't have li items inside our own LI at L126
component="div"
Copy link
Member

@fzaninotto fzaninotto Sep 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this one? This change removes the hand mouse pointer on list items, and I think that the UX is more important than the DOM validation.

@fzaninotto fzaninotto merged commit b0f9974 into next Sep 27, 2021
@fzaninotto fzaninotto deleted the simplelist-custom-url-support branch September 27, 2021 14:32
@djhi djhi mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.19
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto