Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass null to TrueIcon or FalseIcon in <BooleanField> #8760

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Add ability to pass null to TrueIcon or FalseIcon in <BooleanField> #8760

merged 1 commit into from
Mar 23, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Mar 23, 2023

No description provided.

@slax57 slax57 added the RFR Ready For Review label Mar 23, 2023
@djhi djhi added this to the 4.9.0 milestone Mar 23, 2023
@djhi djhi merged commit ef7524b into next Mar 23, 2023
@djhi djhi deleted the BooleanField-null-FalseIcon branch March 23, 2023 11:04
@davidhenley
Copy link
Contributor

davidhenley commented Mar 28, 2023 •
edited
Loading

Shouldn't this be false instead of null to align with other React-Admin examples like passing false to bulkActionButtons?

I've just been passing MUI's Icon when I wanted to hide this.

@slax57
Copy link
Contributor Author

slax57 commented Mar 29, 2023

@davidhenley I tend to agree with you. If this is something that will be useful to you, feel free to open a PR and I'll accept it. Thanks 🙂

@davidhenley davidhenley mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slax57 @davidhenley @djhi