Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout padding inconsistency on low resolution screens #8794

Merged

Conversation

soullivaneuh
Copy link
Contributor

@soullivaneuh soullivaneuh commented Apr 3, 2023

Summary

Before

Screen Shot 2023-04-03 at 20 39 14

After

Screen Shot 2023-04-03 at 20 42 11

Its a fix of the configuration introduced in 48e4a91.

I am not sure it was intended, but it make more sense to me.

@fzaninotto
Copy link
Member

I'm sorry, your 2 screenshots are too big to fit both in one screen and spot the differences.

Would you mind making the visual diff more obvious?

@soullivaneuh
Copy link
Contributor Author

Updated! The important part is the padding right of the main layout.

@slax57 slax57 added this to the 4.9.2 milestone Apr 4, 2023
@slax57 slax57 merged commit 790d2b3 into marmelab:master Apr 4, 2023
@slax57
Copy link
Contributor

slax57 commented Apr 4, 2023

Thanks!

@slax57 slax57 changed the title fix: layout padding inconsistency on low resolution screens Fix layout padding inconsistency on low resolution screens Apr 4, 2023
@soullivaneuh soullivaneuh deleted the layout-mobile-consistent-padding branch April 4, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants