Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some utility generics for better typings #8815

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Add some utility generics for better typings #8815

merged 2 commits into from
Apr 7, 2023

Conversation

IAmVisco
Copy link
Contributor

@IAmVisco IAmVisco commented Apr 6, 2023

Summary

Just a couple of generics that should be there.

djhi
djhi requested changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is technically a new feature though. Can you target the next branch?

@IAmVisco IAmVisco changed the base branch from master to next April 7, 2023 08:25
@IAmVisco IAmVisco requested a review from djhi April 7, 2023 08:31
djhi
djhi approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi merged commit 4eb4f4c into marmelab:next Apr 7, 2023
@djhi djhi added this to the 4.10.0 milestone Apr 7, 2023
@IAmVisco IAmVisco deleted the add-utility-generics branch October 7, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@IAmVisco @djhi