Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning about string value passed to BooleanInput #9056

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix warning about string value passed to BooleanInput #9056

merged 1 commit into from
Jun 28, 2023

Conversation

adguernier
Copy link
Contributor

Cast field.value passed to checked prop in boolean, to avoid checked prop to be <empty string> in <BooleanInput>
Fix #9042

@adguernier
Fix: force value passed to checked prop to be boolean
7492ecf 
Cast field.value passed to checked prop in boolean, to avoid checked prop to be <empty string> in BooleanInput
@adguernier adguernier added the RFR Ready For Review label Jun 28, 2023
@djhi djhi added this to the 4.11.5 milestone Jun 28, 2023
@djhi djhi merged commit 70d9e4d into master Jun 28, 2023
@djhi djhi deleted the 9042-fix-string-given-to-booleaninput branch June 28, 2023 08:09
@slax57 slax57 modified the milestones: 4.11.5, 4.12.0 Jul 3, 2023
@slax57 slax57 changed the title Fix: string value supplied to BooleanInput checked prop Fix warning about string value passed to BooleanInput Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

String value supplied to BooleanInput when used with ArrayInput
3 participants
@adguernier @djhi @slax57