This repository has been archived by the owner on Jan 15, 2020. It is now read-only.
[RFR] Allow to comment from the commit list #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try a sed comment from a commit (and not from the `Files changed` tab), and/or we write a sed comment from the deletion side of the review, the GitHub API might not send the `position` of the diff hunk but its `original_position`. This PR should fix #79
fzaninotto
approved these changes
May 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try a sed comment from a commit (and not from the
Files changedtab),and/or we write a sed comment from the deletion side of the review, the
GitHub API might not send the
positionof the diff hunk but itsoriginal_position.This PR should fix #79