This repository has been archived by the owner on Jan 15, 2020. It is now read-only.
[RFR] Remove 'No newline at end of file' from diffs #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kmaschta
force-pushed
the
fix-empty-lines-warnings
branch
from
3fe232c
to
f47417b
Compare
alexisjanvier
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was initialy declared here: #79 (comment)
Explanation
In files that doesn't contain an empty line at the end of the file, GitHub notices it and display a small logo in the pull request.
Also, this no existing line is virtually added in the diff sent by the GitHub API (and by git btw) containing:
Sedy have to parse the informations of the diff sent by the GitHub API to find the line to edit the specified file.
So, this no existing line added in the diff diformed the correct line number.
This PR aims to remove this virtual line and fix the line count in the diff.