-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swift3.0 #34
Feature/swift3.0 #34
Conversation
+Updated Schemes to follow XCode 8's recommended settings
Please, update your brach with xCode 8 b4 |
I created a pull request for @mostafaberg fork. I can send over a patch as well if needed. |
@macness-pavelh thanks a lot for the great work, will look into it now :) |
fixes for XC8 beta 4
Thanks a lot @mostafaberg and @macness-pavelh (and @mvyrko). I just created a Swift 3.0 branch, can you point your PR there and I will accept it. Thanks. |
@marmelroy sure thing, will PR now, hopefully the tests will pass with the proper configurations |
Great! For the tests to pass you will need to update .travis.yml and build.sh too 😄 |
No problems, do you know which values to use ? |
In the Travis file change osx_image to
In the build file change the top to:
|
Closing this and using #36 instead |
+This PR includes changes to the source files and the test cases that Utilizes Swift 3.0
+Tests have been run and all pass
+Verified filesystem to confirm zip files work on the device properly
+Tested on XCode 8.0b3 (8S174q)