Feature/swift3.0 #34
Closed
Feature/swift3.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2016 10:51
+Updated Schemes to follow XCode 8's recommended settings
Closed
|
Please, update your brach with xCode 8 b4 |
|
I created a pull request for @mostafaberg fork. I can send over a patch as well if needed. |
|
@macness-pavelh thanks a lot for the great work, will look into it now :) |
fixes for XC8 beta 4
|
Thanks a lot @mostafaberg and @macness-pavelh (and @mvyrko). I just created a Swift 3.0 branch, can you point your PR there and I will accept it. Thanks. |
|
@marmelroy sure thing, will PR now, hopefully the tests will pass with the proper configurations |
|
Great! For the tests to pass you will need to update .travis.yml and build.sh too 😄 |
|
No problems, do you know which values to use ? |
|
In the Travis file change osx_image to In the build file change the top to: |
|
Closing this and using #36 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+This PR includes changes to the source files and the test cases that Utilizes Swift 3.0
+Tests have been run and all pass
+Verified filesystem to confirm zip files work on the device properly
+Tested on XCode 8.0b3 (8S174q)