Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better formatting and a version of AsYouTypeFormatter #2

Closed
marmelroy opened this issue Oct 27, 2015 · 12 comments
Closed

Better formatting and a version of AsYouTypeFormatter #2

marmelroy opened this issue Oct 27, 2015 · 12 comments

Comments

@marmelroy
Copy link
Owner

Formatting of parsed phone numbers for display is still very basic in 0.1 and should be improved in the next version.

Also, an equivalent to libPhoneNumber's AsYouTypeFormatter would be useful and still within the scope of this framework.

@marmelroy
Copy link
Owner Author

Better formatter done. Matches Google's libPhoneNumber.

AsYouTypeFormatter coming soon.

@andresgarza
Copy link

+1

@marmelroy
Copy link
Owner Author

Thanks @andresgarza! Got a little distracted away from the AsYouTypeFormatter. Expecting to have a working version during the week.

@andresgarza
Copy link

@marmelroy thanks!, will definitely try it out and send some feedback

@marmelroy
Copy link
Owner Author

Still unfinished I'm afraid but a lot of progress was made. There are some unexpected challenges in allowing a user to edit any part of the textfield and keeping the cursor at a logical place. Will figure out a solution soon.

@andresgarza
Copy link

@marmelroy not sure if it helps at all, but a trick i've seen for formatting credit cards numbers is to use letter spacing (kerning) to fake spaces (as opposed to actually adding spaces to text in textfield)

@irace
Copy link

irace commented Jan 28, 2016

Any update on when it's expected that the AsYouTypeFormatter might land?

@marmelroy
Copy link
Owner Author

Hi @irace, I've been very very busy but getting the AsYouTypeFormatter is my only open source goal for the coming week. Let's commit to it landing by 5th Feb.

@irace
Copy link

irace commented Feb 2, 2016

Sounds great. Thanks for the update!

@marmelroy
Copy link
Owner Author

Late but making progress 😿

@marmelroy
Copy link
Owner Author

Getting close. Check out progress on https://github.com/marmelroy/PhoneNumberKit/tree/feature_asyoutypeformatter

It works well now but there's one rare bug left on deletion from the middle. Also, the code needs a little clean up + documentation and tests.

@marmelroy
Copy link
Owner Author

Released in 0.6 (finally)

redcapua added a commit to redcapua/PhoneNumberKit that referenced this issue Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants