-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better formatting and a version of AsYouTypeFormatter #2
Comments
Better formatter done. Matches Google's libPhoneNumber. AsYouTypeFormatter coming soon. |
+1 |
Thanks @andresgarza! Got a little distracted away from the AsYouTypeFormatter. Expecting to have a working version during the week. |
@marmelroy thanks!, will definitely try it out and send some feedback |
Still unfinished I'm afraid but a lot of progress was made. There are some unexpected challenges in allowing a user to edit any part of the textfield and keeping the cursor at a logical place. Will figure out a solution soon. |
@marmelroy not sure if it helps at all, but a trick i've seen for formatting credit cards numbers is to use letter spacing (kerning) to fake spaces (as opposed to actually adding spaces to text in textfield) |
Any update on when it's expected that the AsYouTypeFormatter might land? |
Hi @irace, I've been very very busy but getting the AsYouTypeFormatter is my only open source goal for the coming week. Let's commit to it landing by 5th Feb. |
Sounds great. Thanks for the update! |
Late but making progress 😿 |
Getting close. Check out progress on https://github.com/marmelroy/PhoneNumberKit/tree/feature_asyoutypeformatter It works well now but there's one rare bug left on deletion from the middle. Also, the code needs a little clean up + documentation and tests. |
Released in 0.6 (finally) |
Formatting of parsed phone numbers for display is still very basic in 0.1 and should be improved in the next version.
Also, an equivalent to libPhoneNumber's AsYouTypeFormatter would be useful and still within the scope of this framework.
The text was updated successfully, but these errors were encountered: