Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview doesn't update after making changes to custom theme file #346

Closed
frazane opened this issue Apr 22, 2022 · 4 comments
Closed

Comments

@frazane
Copy link

frazane commented Apr 22, 2022

Version of Marp Tool

Marp for VS Code v1.5.1

Operating System

Windows

Environment

OS version: Windows 10
VS Code version (Marp for VS Code): v1.66.2

How to reproduce

  • Create a new Markdown file with a custom theme defined in a separate local file.
  • Open the preview.
  • Make some changes to the custom theme (e.g. change background color) and save.

Expected behavior

Replaces the current Markdown preview to the updated theme.

Actual behavior

The outdated Markdown preview does not show new theme changes.

Additional information

By reloading the window, the expected changes will apply.

error

Might be related to #345 ?

@yhatt
Copy link
Member

yhatt commented Apr 22, 2022

Related?: marp-team/marp#288

@yhatt
Copy link
Member

yhatt commented Apr 22, 2022

At least I could not reproduce that in my VS Code on Windows 10. Could you share a reproducible example as a repository?

@frazane
Copy link
Author

frazane commented Apr 23, 2022

Turns out there's a problem when locating the workspace on a NFS. I tried the same exact configuration in a workspace located on my physical machine and it worked. No idea why this happens...it would be interesting to know if others have the same issue, but my guess is that's probably not related to marp. So feel free to close the issue if you want @yhatt and thanks!

@yhatt
Copy link
Member

yhatt commented Apr 29, 2022

OK, thank you for providing a detailed context. 😃

@yhatt yhatt closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants