feat: add type predicate overloading of 'filter' function #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbl428
commented
Nov 20, 2021
| @@ -92,14 +92,14 @@ function uniqBy<A extends Iterable<unknown> | AsyncIterable<unknown>, B>( | |||
|
|
|||
| if (isIterable(iterable)) { | |||
| return pipe( | |||
| iterable as Iterable<IterableInfer<A>>, | |||
| iterable, | |||
| filter((a) => pipe1(f(a), checkAndAdd)), | |||
There was a problem hiding this comment.
I change this line to remove type error.
It was caused by following definition.
function filter<
A extends Iterable<unknown> | AsyncIterable<unknown>,
B extends IterableInfer<A>,
>(
f: (a: IterableInfer<A>) => a is B,
): (iterable: A) => ReturnIterableIteratorType<A, B>;I can not sure it is right definition.
jbl428
force-pushed
the
add-overload-type
branch
from
bb87184
to
02cc7e0
Compare
jbl428
commented
Nov 20, 2021
| @@ -85,7 +85,7 @@ | |||
| "prettier --write", | |||
| "git add" | |||
| ], | |||
| "*.json": [ | |||
| "*.(json|md)": [ | |||
There was a problem hiding this comment.
pre commit hook did not check markdown files but CI does.
so CI failed if someone edit markdown file and did not run prettier.
ppeeou
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
type predicatework as expected in filter function.I forgot to add this one in previous PR 😄