Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change isEmpty logic #208

Merged
merged 1 commit into from
May 31, 2023
Merged

refactor: change isEmpty logic #208

merged 1 commit into from
May 31, 2023

Conversation

rojiwon123
Copy link
Contributor

@rojiwon123 rojiwon123 commented May 30, 2023 •
edited
Loading

if value is object, it have to literal object and have no method and property.
if value is instance of class, isEmpty always return true. ex) Date, Custom Class, .....

  • but array instance is considered to have item or not.

ppeeou
ppeeou approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ppeeou ppeeou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shine1594 shine1594 merged commit f5a7904 into marpple:main May 31, 2023
@rojiwon123 rojiwon123 deleted the refactor/isEmpty branch June 2, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shine1594 shine1594 shine1594 approved these changes

@ppeeou ppeeou ppeeou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rojiwon123 @shine1594 @ppeeou