Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dropWhile function #23

Merged
merged 8 commits into from
Nov 28, 2021
Merged

feat: add dropWhile function #23

merged 8 commits into from
Nov 28, 2021

Conversation

ppeeou
Copy link
Member

@ppeeou ppeeou commented Nov 26, 2021

Fixes #22

@ppeeou ppeeou marked this pull request as draft November 26, 2021 07:22
@ppeeou ppeeou marked this pull request as ready for review November 26, 2021 07:37
@ppeeou ppeeou marked this pull request as draft November 26, 2021 08:11
@ppeeou ppeeou marked this pull request as ready for review November 26, 2021 09:30
shine1594
shine1594 approved these changes Nov 26, 2021
View reviewed changes
Copy link
Collaborator

@shine1594 shine1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@ppeeou ppeeou merged commit 0378a65 into main Nov 28, 2021
@ppeeou ppeeou deleted the feature/#22 branch November 28, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shine1594 shine1594 shine1594 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature dropWhile dropUntil function
2 participants
@ppeeou @shine1594