-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable search timeout #813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicilliar
had a problem deploying
to
marqo-test-suite
April 20, 2024 19:21
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
April 22, 2024 01:05
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
marqo-test-suite
April 22, 2024 03:54
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:54
— with
GitHub Actions
Inactive
farshidz
approved these changes
Apr 23, 2024
farshidz
approved these changes
Apr 23, 2024
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
April 23, 2024 06:58
— with
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
April 23, 2024 06:59
— with
GitHub Actions
Failure
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 06:59
— with
GitHub Actions
Inactive
farshidz
approved these changes
Apr 23, 2024
farshidz
temporarily deployed
to
marqo-test-suite
April 23, 2024 07:47
— with
GitHub Actions
Inactive
farshidz
pushed a commit
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
No configurable search timeout
What is the new behavior (if this is a feature change)?
Configurable search timeout. New env var introduced:
VESPA_SEARCH_TIMEOUT_MS
. Defaults to 1000ms.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
In progress
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements