Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable search timeout #813

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Configurable search timeout #813

merged 7 commits into from
Apr 23, 2024

Conversation

vicilliar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    No configurable search timeout

  • What is the new behavior (if this is a feature change)?
    Configurable search timeout. New env var introduced: VESPA_SEARCH_TIMEOUT_MS. Defaults to 1000ms.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    In progress

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@farshidz farshidz merged commit 97370d4 into mainline Apr 23, 2024
1 check passed
@farshidz farshidz deleted the joshua/search-timeout branch April 23, 2024 07:46
farshidz pushed a commit that referenced this pull request May 22, 2024
farshidz added a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants