Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Model Prewarming #847

Merged
merged 12 commits into from
Jun 3, 2024
Merged

Patch Model Prewarming #847

merged 12 commits into from
Jun 3, 2024

Conversation

RaynorChavez
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature: prewarming patch models

  • What is the current behavior? (You can also link to an open issue here)
    Marqo does not have a mechanism to prewarm patch models

  • What is the new behavior (if this is a feature change)?
    new env var MARQO_PATCH_MODELS_TO_PRELOAD where the user can specify the patch models to prewarm

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes, tests have been created in test_on_start_script.py

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

src/marqo/tensor_search/on_start_script.py Outdated Show resolved Hide resolved
src/marqo/s2_inference/processing/image.py Outdated Show resolved Hide resolved
src/marqo/tensor_search/on_start_script.py Outdated Show resolved Hide resolved
tests/tensor_search/test_on_start_script.py Outdated Show resolved Hide resolved
tests/tensor_search/test_on_start_script.py Show resolved Hide resolved
farshidz
farshidz previously approved these changes Jun 3, 2024
@RaynorChavez RaynorChavez merged commit efb4ab3 into mainline Jun 3, 2024
15 of 16 checks passed
@RaynorChavez RaynorChavez deleted the raynor/dino-prewarm-bug branch June 3, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants