Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Amazon SES issues #61

Merged
merged 1 commit into from
May 6, 2016
Merged

Fix Amazon SES issues #61

merged 1 commit into from
May 6, 2016

Conversation

vitorio
Copy link
Contributor

@vitorio vitorio commented Apr 10, 2016

Using mailer 4.0.1 with Python 2.7 and boto 2.38, the amazon transport doesn't work out of the box.

  • The transport file is called ses.py but the transport is amazon.
  • boto doesn't know what to do with the host argument in the README, and throws this error: TypeError: __init__() got an unexpected keyword argument 'host'
  • boto doesn't know what to do with marrow mailer's use argument, and throws this error: TypeError: __init__() got an unexpected keyword argument 'use'

This pull request resolves these issues by:

  • README.textile now specifies that the transport is called amazon, addressing Update docs that "ses" transport is actually "amazon".  #57 (although not providing an ses alias).
  • The host line is removed from README.textile.
  • The use argument is popped before any other parameters are passed into config.

With these changes I can successfully send mail.

@codecov-io
Copy link

Current coverage is 85.28%

Merging #61 into develop will not affect coverage as of 1cf96dc

@@            develop     #61   diff @@
=======================================
  Files            10      10       
  Stmts           768     768       
  Branches          0       0       
  Methods           0       0       
=======================================
  Hit             655     655       
  Partial           0       0       
  Missed          113     113       

Review entire Coverage Diff as of 1cf96dc

Powered by Codecov. Updated on successful CI builds.

@amcgregor amcgregor merged commit e772ae1 into marrow:develop May 6, 2016
@vitorio
Copy link
Contributor Author

vitorio commented May 6, 2016

Thanks!

@amcgregor
Copy link
Member

Same comment as the other PR. ;)

@amcgregor amcgregor added 1.bug An error has been encountered that is preventing utilization. 2.enhancement A request for a new feature or altered behaviour. transport:ses labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.bug An error has been encountered that is preventing utilization. 2.enhancement A request for a new feature or altered behaviour. transport:ses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants