Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Py3 compatibility #67

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

frenzymadness
Copy link
Contributor

Hello.

I downloaded the latest release of the mailer from PyPI and when I tried to run python setup.py install with Python 3.5.1 I get the following error:

byte-compiling build/bdist.linux-x86_64/egg/marrow/mailer/transport/postmark.py to postmark.cpython-35.pyc
  File "build/bdist.linux-x86_64/egg/marrow/mailer/transport/postmark.py", line 68
    except (urllib2.HTTPError, urllib2.URLError), e:
                                                ^
SyntaxError: invalid syntax

It looks like Python 3 incompatibility so I've changed this line and now installation works for Python 2 and 3.

@frenzymadness
Copy link
Contributor Author

I have one more question. Could you please make a new release on PyPI with README.textile and LICENSE.txt included in tarball?

Thank you.

@codecov-io
Copy link

codecov-io commented Jul 20, 2016

Current coverage is 85.39%

Merging #67 into develop will not change coverage

@@            develop        #67   diff @@
==========================================
  Files            10         10          
  Lines           767        767          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            655        655          
  Misses          112        112          
  Partials          0          0          

Powered by Codecov. Last updated by a0469f8...e0b0995

@amcgregor amcgregor merged commit 5efd89d into marrow:develop Sep 9, 2016
@amcgregor amcgregor added 1.bug An error has been encountered that is preventing utilization. transport:postmark Postmark API transport. labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.bug An error has been encountered that is preventing utilization. transport:postmark Postmark API transport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants