Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GroupBy.{cumcount,cummin,cummax,cumprod,cumsum} #1069

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Mar 17, 2020

What do these changes do?

Add support for GroupBy.{cumcount,cummin,cummax,cumprod,cumsum}

Related issue number

Fixes #1068

@wjsi wjsi added type: feature New feature mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Mar 17, 2020
@wjsi wjsi added this to the v0.4.0b1 milestone Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1069 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1069      +/-   ##
==========================================
+ Coverage    92.8%   92.87%   +0.07%     
==========================================
  Files         622      626       +4     
  Lines       47700    48182     +482     
  Branches     7058     7112      +54     
==========================================
+ Hits        44267    44751     +484     
+ Misses       2285     2276       -9     
- Partials     1148     1155       +7
Impacted Files Coverage Δ
mars/operands.py 93.58% <100%> (+0.01%) ⬆️
mars/dataframe/groupby/cum.py 100% <100%> (ø)
mars/dataframe/groupby/apply.py 94.91% <100%> (-0.05%) ⬇️
mars/dataframe/groupby/__init__.py 100% <100%> (ø) ⬆️
mars/web/session.py 74.91% <0%> (-1.38%) ⬇️
mars/scheduler/session.py 96.44% <0%> (-1.19%) ⬇️
mars/scheduler/operands/base.py 94.56% <0%> (-1.09%) ⬇️
mars/scheduler/operands/shuffle.py 91.2% <0%> (-0.8%) ⬇️
mars/worker/storage/core.py 93.14% <0%> (-0.41%) ⬇️
mars/dataframe/base/__init__.py 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cade0f3...d40aa15. Read the comment docs.

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit d99732d into mars-project:master Mar 17, 2020
@wjsi wjsi deleted the feature/groupby_cum branch March 17, 2020 08:15
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GroupBy.{cumcount,cummin,cummax,cumprod,cumsum}
2 participants