[Ray] Rerun subtask for ray backend #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyile
force-pushed
the
rerun_subtask_ray
branch
2 times, most recently
from
18df6ef
to
2695c6f
Compare
keyile
changed the title
|
Still some issue with codacy: https://app.codacy.com/gh/mars-project/mars/pullRequest?prid=7861162 |
|
@qinxuye Thanks for helping. I'm working on improving it. |
fyrestone
reviewed
Aug 5, 2021
keyile
force-pushed
the
rerun_subtask_ray
branch
from
2695c6f
to
2084930
Compare
keyile
force-pushed
the
rerun_subtask_ray
branch
from
2084930
to
fdd26d4
Compare
keyile
requested review from
chaokunyang,
hekaisheng and
qinxuye
as code owners
|
Will review ASAP, we plan to release v0.8.0a1 as well as v0.7.0 soon enough, hope this could be merged soon after that. |
wjsi
changed the title
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Aug 9, 2021
|
Thanks for your contribution, look forward to seeing more contributions from you. |
chaokunyang
pushed a commit
to chaokunyang/mars
that referenced
this pull request
Aug 16, 2021
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Aug 18, 2021
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR generally adds support of basic rerun subtask for ray backend, and is basically the subsequent work for #2198. The details are as follows.
Note: This PR changes back to one way channel for ray backend communication, which can have some side effects. If there are better ways to achieve the ServerClosed support, it's ok to change this.