Improve wait_actor_pool_recovered #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyile
requested review from
chaokunyang,
fyrestone,
qinxuye and
wjsi
as code owners
wjsi
reviewed
Aug 13, 2021
| if self._auto_recover and message.address not in self._recover_events: | ||
| self._recover_events[message.address] = asyncio.Event() | ||
| if self._auto_recover and message.address not in self._recover_events: | ||
| self._recover_events[message.address] = asyncio.Event() |
There was a problem hiding this comment.
I think one single event object plus a lock is enough. Recover event is created during pool initialization and replaced with a new event object every time when a monitor loop finishes.
qinxuye
added
mod: actor
type: enhancement
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Aug 18, 2021
(cherry picked from commit 2fb00d8)
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Aug 18, 2021
(cherry picked from commit 2fb00d8)
wjsi
pushed a commit
that referenced
this pull request
Aug 18, 2021
wjsi
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR enhances reliability of wait_actor_pool_recovered and avoid waiting forever. The changes are small and the ideas are below:
This PR also adds tests for auto-recover and server-closed for ray as mars pool does.
Related issue number
Resolve #2320