Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Proxima work with latest Mars #2599

Merged
merged 4 commits into from
Dec 3, 2021

Conversation

yuyiming
Copy link
Collaborator

@yuyiming yuyiming commented Dec 3, 2021

  • The first arg of TensorSlice should be a set instead of a list;
  • Most chunks in ProximaBuilder are bundled to specified workers, but only start-OPs are assigned during analyzing. I assign other chunks;

@hekaisheng hekaisheng added mod: learn to be backported Indicate that the PR need to be backported to stable branch type: bug Something isn't working labels Dec 3, 2021
@hekaisheng hekaisheng added this to the v0.9.0a1 milestone Dec 3, 2021
@wjsi wjsi changed the title making Proxima compatible with master Make Proxima work with latest Mars Dec 3, 2021
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 0b70425 into mars-project:master Dec 3, 2021
@yuyiming yuyiming deleted the github_fix_proxima branch December 5, 2021 03:34
wjsi pushed a commit to wjsi/mars that referenced this pull request Dec 7, 2021
hekaisheng pushed a commit that referenced this pull request Dec 8, 2021
Co-authored-by: yuyiming <36940796+yuyiming@users.noreply.github.com>
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Dec 8, 2021
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request May 31, 2022
Merge branch fix_proxima of git@gitlab.alipay-inc.com:ray-project/mars.git into master
https://code.alipay.com/ray-project/mars/pull_requests/138

Signed-off-by: 捕牛 <hejialing.hjl@antgroup.com>


* Make Proxima work with latest Mars (mars-project#2599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: learn type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants