Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix df.loc[:] to make sure same index_value key generated #2643

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Jan 21, 2022

What do these changes do?

This PR fixes df.loc[:] to make sure same index_value key generated

Related issue number

Fixes #2642

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Jan 21, 2022
@qinxuye qinxuye added this to the v0.9.0a2 milestone Jan 21, 2022
@wjsi wjsi force-pushed the bugfix/df-loc-index-value-key branch from f65ae0c to 65ab555 Compare January 21, 2022 07:51
@wjsi wjsi force-pushed the bugfix/df-loc-index-value-key branch from 65ab555 to f96f261 Compare January 21, 2022 07:52
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 0df26c5 into mars-project:master Jan 24, 2022
@qinxuye qinxuye deleted the bugfix/df-loc-index-value-key branch January 24, 2022 06:16
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] df.loc[:] generates a different index_value key from original one
3 participants