Respect JSON_SORT_KEYS in _generate_etag #305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all, there is no reason to force this here. Respecting the setting from Flask makes things more consistent with payload dump.
This change will affect users setting
JSON_SORT_KEYS
toFalse
in that generated ETags will now differ if the order of the dict payload changes. This makes sense for a strong ETag.There are more things I'd like to clean up in the ETag feature. We're doing too much in flask-smorest and we should rely more on Flask/Werkzeug. This is just an easy first step.
This could be considered a (minor) bug fix. And a (slightly) breaking change.