Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets max age #231

Merged
merged 6 commits into from
May 25, 2024
Merged

Assets max age #231

merged 6 commits into from
May 25, 2024

Conversation

kates
Copy link
Contributor

@kates kates commented May 23, 2024

Allow changing the max-age value in the settings. It still retain the default 3600s if max_age is not configured.

#221

ellmetha
ellmetha approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@ellmetha ellmetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🙏 Left a couple of minor comments, we should be able to merge this after those are addressed. 😃

spec/marten/middleware/asset_serving_spec.cr Outdated Show resolved Hide resolved
spec/marten/middleware/asset_serving_spec.cr Outdated Show resolved Hide resolved
src/marten/middleware/asset_serving.cr Outdated Show resolved Hide resolved
spec/marten/conf/global_settings/assets_spec.cr Outdated Show resolved Hide resolved
@ellmetha
Copy link
Member

Thanks for adding this! 🙏

@ellmetha ellmetha merged commit f9ac557 into martenframework:main May 25, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellmetha ellmetha ellmetha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kates @ellmetha