Add github builtin authorization to support private repos #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @fiskhest! The Action was originally developed for public repositories but the token addition makes it compatible with private ones too. 👍🏻 |
|
🙏👍 Cheers for the quick response! 🎉 |
|
@martialonline I might've messed something up with the PR, but a new tag was never built so there's no v3 tag pointing to the latest commit (I'm currently bypassing this by checking out master instead but would prefer a tag). Could you possibly have a look? |
|
@fiskhest all done - published the v3 release. Sorry it took a while! |
|
No worries, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my own testing and #5 it seems like this action currently only works for public repositories. I needed it in a private repository, and the fix is real simple.
Whenever Github Actions is enabled for a repository, a Github Apps is installed and the
${{ github.token }}variable is exposed.The proposed changes piggybacks on the fact that variable will always be populated and thus we can lookup the workflow status for both private and public repositories.