rounder: Fix invalid creation of zero-size bit-vector. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes martin-cs#8. This fixes an issue where the rounder attempts to generate a bit-vector of size 0 in fixedPositionRound() when converting an FP to an unsigned BV of size 1.
aniemetz
added a commit
to cvc5/symfpu
that referenced
this pull request
Jun 27, 2023
This fixes an issue where the rounder attempts to generate a bit-vector of size 0 in fixedPositionRound() when converting an FP to an unsigned BV of size 1. This has been submitted as PR martin-cs#9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8.
This fixes an issue where the rounder attempts to generate a bit-vector of size 0 in fixedPositionRound() when converting an FP to an unsigned BV of size 1.
This was tested for both Bitwuzla and cvc5 (against with/without patch and against Z3) on all
*FP*benchmarks in SMT-LIB, and with Murxla.