Improve performance for large files #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmltodict becomes slow when you have an XML file with large texts.
Enabling the parser.buffer_text option dramatically increases performance.
Code used to benchmark:
import xmltodict
import time
xml = "<root>" + ("a"*70+"\n")*10000 + "</root>"
s=time.time()
x=xmltodict.parse(xml)
print(time.time() - s)
# 19.9860811234 seconds without buffer_text
# 0.059289932251 seconds with buffer_text
# So 300 times faster
|
That's awesome, thank you for this contribution! |
martinblech
added a commit
that referenced
this pull request
Mar 27, 2014
Improve performance for large files
markjdb
pushed a commit
to markjdb/freebsd-ports
that referenced
this pull request
Apr 12, 2014
- Add TEST_DEPENDS in preparation of automatic test infrastructure Changelog: * Improve performance for large files [1] [1] martinblech/xmltodict#56 PR: 188252 Submitted by: myself Approved by: koobs@ (mentor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmltodict becomes slow when you have an XML file with large texts.
Enabling the parser.buffer_text option dramatically increases performance.
Benchmark below. Unittests still work.
Code used to benchmark:
import xmltodict import time xml = "<root>" + ("a"*70+"\n")*10000 + "</root>" s=time.time() x=xmltodict.parse(xml) print(time.time() - s)#19.9860811234 seconds without buffer_text
#0.059289932251 seconds with buffer_text
So 300 times faster