Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace current ordering with a more natural "Depth First" #5

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Replace current ordering with a more natural "Depth First" #5

merged 3 commits into from
Jun 9, 2022

Conversation

SimonMarquis
Copy link
Contributor

And replace MutableList with LinkedList.
Which is a tiny bit more performant for those LIFO stacks.
~40% faster on synthetic benchmark.

@SimonMarquis
Add XmlNodeTest walk
937bc06
@SimonMarquis
Replace current ordering with a more natural "Depth First"
5844803
@SimonMarquis
Replace MutableList with LinkedList
ffe4a4c 
Which is a tiny bit more performant for those LIFO stacks.
~40% faster on synthetic benchmark.
martinbonnin
martinbonnin approved these changes Jun 9, 2022
View reviewed changes
Copy link
Owner

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit b42920b into martinbonnin:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonMarquis @martinbonnin